RFR: 7175396: The text on label is not painted red for Nimbus LaF. [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Sep 29 09:24:25 UTC 2022


On Wed, 28 Sep 2022 15:03:41 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test fix
>
> test/jdk/javax/swing/plaf/nimbus/TestNimbusLabel.java line 47:
> 
>> 45: {
>> 46:     private static JFrame frame;
>> 47:     private static int colorTolerance = 5;
> 
> Let's add `final` to the constant.

ok

> test/jdk/javax/swing/plaf/nimbus/TestNimbusLabel.java line 106:
> 
>> 104:                     robot.createScreenCapture(new Rectangle(p.x, p.y,
>> 105:                             d.width,
>> 106:                             d.height));
> 
> Suggestion:
> 
>                     robot.createScreenCapture(new Rectangle(p, d));

ok

-------------

PR: https://git.openjdk.org/jdk/pull/9900



More information about the client-libs-dev mailing list