RFR: JDK-8292276 : Missing color names in CSS [v23]

[Alexey Ivanov]

On Wed, 28 Sep 2022 17:13:42 GMT, ScientificWare <duke at openjdk.org> wrote:

>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Missing color names in CSS](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8292276)
>> 
>> This is tracked in JBS as 
>> - [JDK-8292276 : Missing color names in CSS](https://bugs.openjdk.java.net/browse/JDK-8292276)
>> 
>> Adds missing color names, defined by CSS Level 4, in CSS.java :
>> CSS Color Module Level 4
>> W3C Candidate Recommendation Snapshot, 5 July 2022
>> [7.1 Named Colors](https://www.w3.org/TR/css-color-4/#named-color)
>> 
>> Designed from : [ScientificWare JDK-8292276 : Missing color names in CSS](https://github.com/scientificware/jdk/issues/12)
>
> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
> 
>    Moves jtreg tags to the class declaration
>   
>   Comment with tags isn't collapsed when viewed in an IDE if it's placed before the class declaration.

> > Should it be an enhancement?
> 
> corrects or changes `Orange` value in (bug ?)

It's probably a bug. `'Orange'` shouldn't have been there. Both [HTML 3.2](https://www.w3.org/TR/2018/SPSD-html32-20180315/#body) and [CSS 1](https://www.w3.org/TR/REC-CSS1/#color-units) declare only 16 colors from Windows VGA palette.

> adds new values + improve performance (enhancements)
> 
> So I think it's rather an enhancement.  
> Why is it important to qualifying this?

I've changed the type of the issue from bug to enhancement. This PR changes the specified behaviour of a public method [`StyleSheet.stringToColor`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/html/StyleSheet.html#stringToColor(java.lang.String)). It is explicitly specified, “This will only convert the HTML3.2 color strings or a string of length 7; otherwise, it will return null.” Thus, the current behaviour is *not a bug*. What you propose is an enhancement.

> I've submitted a test job with this fix.

And one JCK (Java Compatibility Kit) test fails, the one which verifies the statement that I quoted above.

You need to update the specification of `StyleSheet.stringToColor`. Once we agree on the text in this PR, I'll submit a CSR for you. This PR can be integrated only after the CSR is approved.

Shall I edit the subject of the issue to be more specific? *“Add named colors from CSS Color Module Level 4”?*

-------------

PR: https://git.openjdk.org/jdk/pull/9825