RFR: 8278086: [REDO] ImageIO.write() method will throw IndexOutOfBoundsException [v2]

[Phil Race]

On Mon, 26 Sep 2022 13:20:36 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> This is redo of https://bugs.openjdk.org/browse/JDK-8262297
>> In https://bugs.openjdk.org/browse/JDK-8262297 we added similar change but we didnt allow 15bpp image in BMP, because of which many tests which were using USHORT_555_RGB format were failing as reported at https://bugs.openjdk.org/browse/JDK-8278047
>> 
>> There is ambiguity on whether we should support 15bpp BMP encoding also or not as captured in JBS : https://bugs.openjdk.org/browse/JDK-8278086?focusedCommentId=14521952&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14521952
>> 
>> Since adding tighter condition to only allow 0, 1, 4, 8, 16, 24 and 32 bpp is causing many failures. I have modified the check to allow 15bpp also.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove biType variable

src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java line 1463:

> 1461:             return false;
> 1462:         }
> 1463:         if (compressionType == BI_RLE4 && bpp != 4) {

I'm confused. You say you are relaxing the test to allow 15bpp, but I don't see where you're removing
anything that would have rejected 15bpp.

And how does this prevent the un-specified exception being thrown ?

-------------

PR: https://git.openjdk.org/jdk/pull/10419