RFR: 8283404: [macos] a11y : Screen magnifier does not show JMenu name [v2]
M4ximumPizza
duke at openjdk.org
Sun Apr 2 07:21:17 UTC 2023
On Fri, 31 Mar 2023 17:08:19 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> It seems that the accessibility role returned by the MenuAccessibility class is not correct for top level menu.
>>
>> Added a condition check to return the accessibility role as `NSAccessibilityMenuBarItemRole` in stead of `NSAccessibilityMenuRole` for top level menu whose parent is `menubar`.
>>
>> The solution works correctly for screen magnifier as well as voice over.
>>
>> A manual test case is added to verify the fix.
>>
>> Note: Tried implementing few a11y methods to fix but for top level menu with `NSAccessibilityMenuRole` doesn't return the a11y label.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Test instruction update
Marked as reviewed by M4ximumPizza at github.com (no known OpenJDK username).
-------------
PR Review: https://git.openjdk.org/jdk/pull/13271#pullrequestreview-1368033163
More information about the client-libs-dev
mailing list