RFR: 8305352: updateIconImages may lead to deadlock after JDK-8276849

[Dmitry Cherepanov]

On Mon, 3 Apr 2023 10:00:45 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

>>> Will we call "updateIconImages" when later we show the window or an update of the icons will be missed if the notification come when the window is invisible?
>> 
>> updateIconImages() will still be called from WWindowPeer.initialize() when we show a new window
>
>> It seems that the root cause is a cyclic dependency between GraphicsPrimitiveMgr and Blit during static initialization
> 
> Right, the deadlock might be possible in other scenarios. But it manifests itself more frequently after JDK-8276849 and the change fixes the regression.

> updateIconImages() will still be called from WWindowPeer.initialize() when we show a new window

It's worth mentioning that WindowPeer.initialize() is called on the same thread as setVisible() (i.e. the main thread for the scenario reported in the bug) and so the call to updateIconImages() seems safe

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13263#discussion_r1156859385