RFR: 4130823: Not painting focus when the radio button has only icon

Damon Nguyen dnguyen at openjdk.org
Tue Apr 4 23:25:05 UTC 2023


On Thu, 23 Mar 2023 06:17:18 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Although the issue here is asking about not painting focus when it has icon, however it seems Windows does not draw focus rect for radiobutton at all so instead of closing this as "Not an issue" it is made to not draw the focusrect even when there is text
> 
> This is what can be seen in windows system setting
> 
> ![systemsetting-nofocusrect](https://user-images.githubusercontent.com/43534309/227118784-97d6231d-beb4-4fc9-b760-c47e95817592.png)
> 
> and notepad
> 
> ![notepad-nofocus](https://user-images.githubusercontent.com/43534309/227118824-9d02329f-396d-43b3-aa68-927009a1bd57.png)
> 
> We have currently
> 
> ![beforefix-dashrect](https://user-images.githubusercontent.com/43534309/227119231-19feb2fd-203b-48a2-9e59-62ab63b51ccc.png)
> 
> 
> and after fix
> 
> ![afterfix-nodashrect](https://user-images.githubusercontent.com/43534309/227119263-09be94e2-c6cc-4d7b-9449-a860aabca572.png)

Tested changes and confirmed it works as expected. I noticed the focus still shows for Metal & Motif. Should Metal be updated to reflect the same change?

-------------

Marked as reviewed by dnguyen (Author).

PR Review: https://git.openjdk.org/jdk/pull/13153#pullrequestreview-1371917970



More information about the client-libs-dev mailing list