RFR: 4130823: Not painting focus when the radio button has only icon [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Apr 6 07:01:15 UTC 2023


> Although the issue here is asking about not painting focus when it has icon, however it seems Windows does not draw focus rect for radiobutton at all so instead of closing this as "Not an issue" it is made to not draw the focusrect even when there is text
> 
> This is what can be seen in windows system setting
> 
> ![systemsetting-nofocusrect](https://user-images.githubusercontent.com/43534309/227118784-97d6231d-beb4-4fc9-b760-c47e95817592.png)
> 
> and notepad
> 
> ![notepad-nofocus](https://user-images.githubusercontent.com/43534309/227118824-9d02329f-396d-43b3-aa68-927009a1bd57.png)
> 
> We have currently
> 
> ![beforefix-dashrect](https://user-images.githubusercontent.com/43534309/227119231-19feb2fd-203b-48a2-9e59-62ab63b51ccc.png)
> 
> 
> and after fix
> 
> ![afterfix-nodashrect](https://user-images.githubusercontent.com/43534309/227119263-09be94e2-c6cc-4d7b-9449-a860aabca572.png)

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Test added

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13153/files
  - new: https://git.openjdk.org/jdk/pull/13153/files/6ed26392..60a13228

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13153&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13153&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/13153.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13153/head:pull/13153

PR: https://git.openjdk.org/jdk/pull/13153



More information about the client-libs-dev mailing list