RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v4]

Roger Riggs rriggs at openjdk.org
Thu Apr 6 14:11:19 UTC 2023


On Thu, 6 Apr 2023 03:17:57 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/share/classes/jdk/internal/util/Architecture.java line 39:
> 
>> 37:     X86(),
>> 38:     IA64(),
>> 39:     ARM(),
> 
> Suggestion:
> 
>     ARM32(),

I'm inclined to drop the enum value and isArm method because they are legacy and are not being used in OpenJDK sources.  This could also apply to IA64. 
They can be added if needed and otherwise are just unused bulk.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1159852394



More information about the client-libs-dev mailing list