RFR: 8305527: HarfBuzz: Remove trailing comma from the enum in hb-paint.h

Harshitha Onkar honkar at openjdk.org
Fri Apr 7 19:56:45 UTC 2023


On Fri, 7 Apr 2023 05:32:55 GMT, Phil Race <prr at openjdk.org> wrote:

> > > I don't see why we need this in mainline. I'd prefer to not have it unless we need it.
> > 
> > 
> > I believe it is better to have all JDK branches in sync if it's possible. This change is harmless and as Sergey mentioned it would simplify backport process.
> 
> We'll get it anyway when we upgrade .. that's why we only apply changes that are accepted upstream. And if we upgrade to a version that pre-dates it then we'll have to manually re-apply it for no reason. It is just unnecessary.

@dmarkov20 We will be having a HarfBuzz upgrade to mainline soon. As @prrace suggested, this might be unnecessary at this point then. 

@prrace What about patching it to other branches -17, 20u, is that not required too since we will be backporting the next planned upgrade changes to these branches too?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13328#issuecomment-1500592886



More information about the client-libs-dev mailing list