RFR: 8304912: Use OperatingSystem enum in java.desktop module [v4]
Phil Race
prr at openjdk.org
Sat Apr 8 03:54:47 UTC 2023
On Sat, 8 Apr 2023 00:58:57 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Update classes in the java.desktop module to use the jdk.internal.util.OperatingSystem enum instead of the `os.name` system property to select OS specific behaviors.
>
> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Refactor to use sun.awt.OSInfo instead of system property os.name.
> Modify OSInfo to use jdk.internal.util.OperatingSystem.
> Modify OSInfo.getOSType() to use a cached value and not require doPriv
> or throw SecurityException
> - Merge branch 'master' into 8304912-use-os-desktop
> - Update copyright
> Replaced a few more uses of os.name.
> - Merge branch 'master' into 8304912-use-os-desktop
> - Use OperatingSystem.isAix
> - Remove unused os.arch system property
> - Apply OperatingSystem enum instead of os.name to java.desktop module
Changes requested by prr (Reviewer).
src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java line 2:
> 1: /*
> 2: * Copyright (c) 2000, 2023, Oracle and/or its affiliates. All rights reserved.
no changes so revert (c) year
src/java.desktop/share/classes/sun/swing/WindowsPlacesBar.java line 2:
> 1: /*
> 2: * Copyright (c) 2003, 2023, Oracle and/or its affiliates. All rights reserved.
no changes so revert (c) year
src/java.desktop/unix/classes/sun/font/FcFontConfiguration.java line 2:
> 1: /*
> 2: * Copyright (c) 2008, 2023, Oracle and/or its affiliates. All rights reserved.
no changes so revert (c) year
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java line 2:
> 1: /*
> 2: * Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
no changes so revert (c) year
-------------
PR Review: https://git.openjdk.org/jdk/pull/13213#pullrequestreview-1376698465
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1161056207
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1161056349
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1161056810
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1161056828
More information about the client-libs-dev
mailing list