RFR: 8304912: Use OperatingSystem enum in java.desktop module [v5]

Phil Race prr at openjdk.org
Sat Apr 8 20:27:57 UTC 2023


On Sat, 8 Apr 2023 18:04:33 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Update classes in the java.desktop module to use the jdk.internal.util.OperatingSystem enum instead of the `os.name` system property to select OS specific behaviors.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert copyright in unmodified files; remove unused static

src/java.desktop/share/classes/sun/awt/OSInfo.java line 62:

> 60:     public static final WindowsVersion WINDOWS_2003 = new WindowsVersion(5, 2);
> 61:     public static final WindowsVersion WINDOWS_VISTA = new WindowsVersion(6, 0);
> 62:     public static final WindowsVersion WINDOWS_7 = new WindowsVersion(6, 1);

The  windows version map looks like it hasn't had any love in a long time.
Updating it is VERY out of scope for this fix as it needs some thought in whether to remove old entries
and what to do about replacing them so I filed https://bugs.openjdk.org/browse/JDK-8305777

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1161154446



More information about the client-libs-dev mailing list