Integrated: 4825182: DefaultBoundedRangeModel.setMinimum() changes extent unnecessarily
Prasanta Sadhukhan
psadhukhan at openjdk.org
Mon Apr 10 07:24:57 UTC 2023
On Thu, 6 Apr 2023 14:15:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> [DefaultBoundedRangeModel spec](https://docs.oracle.com/en/java/javase/19/docs/api/java.desktop/javax/swing/DefaultBoundedRangeModel.html#%3Cinit%3E(int,int,int,int))
> set maximum, minimun., extent as per the constraint "min <= value <= value+extent <= max"
> Now, when DefaultBoundedRangeModel.setMinimum() is called with same negative "value" then because of the integer overflow in `setMinimum` method, it causes the `extent `to become 0.
>
> Fix the integer overflow and make sure the extent is not changed unncessarily.
> All jtreg/jck tests are ok.
This pull request has now been integrated.
Changeset: db174a15
Author: Prasanta Sadhukhan <psadhukhan at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/db174a15d18eb8ea9c826592b88f8e690112eaaf
Stats: 72 lines in 2 files changed: 71 ins; 0 del; 1 mod
4825182: DefaultBoundedRangeModel.setMinimum() changes extent unnecessarily
Reviewed-by: prr
-------------
PR: https://git.openjdk.org/jdk/pull/13374
More information about the client-libs-dev
mailing list