RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v10]

Martin Doerr mdoerr at openjdk.org
Tue Apr 11 18:04:49 UTC 2023


On Tue, 11 Apr 2023 17:58:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The value of the system property `os.arch` is unchanged.
>> 
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modified test to check Architecture is64bits() and isLittleEndian()
>   against Unsafe respective values.
>   Relocated code mapping OS name and arch name from PlatformProps to
>   OperatingSystem and Architecture. Kept the mapping of names
>   in the template close to where the values are filled in by the build.

test/jdk/jdk/internal/util/ArchTest.java line 74:

> 72:             case "riscv64" -> RISCV64;  // unverified
> 73:             case "s390x", "s390" -> S390;  // unverified
> 74:             case "ppc64le" -> PPC64;  // unverified

I think "ppc64" should also get mapped to "PPC64".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1163161387



More information about the client-libs-dev mailing list