RFR: 8304915: Create jdk.internal.util.Architecture enum and apply [v12]

Glavo duke at openjdk.org
Tue Apr 11 21:16:46 UTC 2023


On Tue, 11 Apr 2023 21:09:43 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Define an internal jdk.internal.util.Architecture enumeration and static methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, AARCH64, RISCV64, S390, PPC64`
>> Note that `amd64` and `x86_64` in the build are represented by `X64`.
>> The value of the system property `os.arch` is unchanged.
>> 
>> The API is similar to the jdk.internal.util.OperatingSystem enum created by #[12931](https://git.openjdk.org/jdk/pull/12931).
>> Uses in `java.base` and a few others are included but other modules will be done in separate PRs.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correct mapping and test of ppc64

test/jdk/jdk/internal/util/ArchTest.java line 70:

> 68:             case "x86" -> X86;
> 69:             case "i386" -> X86;
> 70:             case "amd64" -> X64;  // Is alias for X86_64

Suggestion:

            case "x86_64", "amd64" -> X64;
            case "x86", "i386" -> X86;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1163340519



More information about the client-libs-dev mailing list