RFR: JDK-8305712: [MacOS] Deprecated Cocoa-NSEvent names [v2]
Harshitha Onkar
honkar at openjdk.org
Tue Apr 11 23:07:35 UTC 2023
On Tue, 11 Apr 2023 23:05:23 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> There are a few deprecated Cocoa NSEvent names currently in use in JDK.
>>
>> https://github.com/openjdk/jdk/blob/jdk-21+17/src/java.desktop/macosx/classes/sun/lwawt/macosx/CocoaConstants.java
>> https://developer.apple.com/documentation/appkit/nsmousemoved
>>
>> Since these event names are marked for deprecation it is better to switch to the newer names.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> copyright year & formatting update
test/jdk/java/awt/Mouse/MacTouchPressEventModifiers/MouseMacTouchPressEventModifiers.java line 4:
> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
> 3: * Copyright (c) 2022, JetBrains s.r.o.. All rights reserved.
> 4: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Not sure if we need to have Oracle and JetBrains copyright here? The test is originally contributed by JetBrains team.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13435#discussion_r1163410619
More information about the client-libs-dev
mailing list