RFR: 6995195: Static initialization deadlock in sun.java2d.loops.Blit and GraphicsPrimitiveMgr

Andrey Turbanov aturbanov at openjdk.org
Thu Apr 13 15:37:32 UTC 2023


On Thu, 13 Apr 2023 13:03:37 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> This PR suggests to move generalPrimitives array to a new static nested GeneralPrimitives class to eliminate the possible deadlock. The Blit class (and other classes that register as general primitives) calls to GeneralPrimitives.register from the static initializer block without acquiring lock on the GraphicsPrimitiveMgr class.
> 
> This PR also includes a jtreg regression test which reproduces this issue without the patch and passes with the patch. Running tests from test/jdk/sun/java2d didn't reveal any issues with this patch.

src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java line 270:

> 268:         }
> 269: 
> 270:         static GraphicsPrimitive locate(int primTypeID) {

it should be marked as `synchronized` too. Otherwise there will possible data race between other thread called `register`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13459#discussion_r1165711469



More information about the client-libs-dev mailing list