RFR: 8304912: Use OperatingSystem enum in java.desktop module [v7]
Glavo
duke at openjdk.org
Thu Apr 13 20:41:41 UTC 2023
On Tue, 11 Apr 2023 16:02:49 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Update classes in the java.desktop module to use the jdk.internal.util.OperatingSystem enum instead of the `os.name` system property to select OS specific behaviors.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed unused osTypeAction
src/java.desktop/share/classes/javax/swing/PopupFactory.java line 1:
> 1: /*
https://github.com/openjdk/jdk/blob/a3334e88440eb576943e20daa7d5ee8f824d1290/src/java.desktop/share/classes/javax/swing/PopupFactory.java#L42
This import is no longer used.
src/java.desktop/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java line 1:
> 1: /*
https://github.com/openjdk/jdk/blob/a3334e88440eb576943e20daa7d5ee8f824d1290/src/java.desktop/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java#L353-L359
This method is no longer used.
src/java.desktop/share/classes/sun/awt/OSInfo.java line 31:
> 29:
> 30: import java.security.AccessController;
> 31: import java.security.PrivilegedAction;
These imports are no longer used.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1165996747
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1165998850
PR Review Comment: https://git.openjdk.org/jdk/pull/13213#discussion_r1166000312
More information about the client-libs-dev
mailing list