RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v5]

[Phil Race]

On Wed, 12 Apr 2023 08:33:28 GMT, Jeremy <duke at openjdk.org> wrote:

>> This resolves a 25 year old P4 ticket: a NullPointerException is printed to System.err needlessly.
>> 
>> This resolution involves confirming that an ImageConsumer is still registered before every notification.
>> 
>> I'll understand if this is rejected as unimportant, but I stumbled across this in the real world the other day and thought this was a simple enough bug to practice on.
>
> Jeremy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   4200096: updating test class header to better describe test

I mean before pushing.

src/java.desktop/share/classes/sun/awt/image/OffScreenImageSource.java line 178:

> 176:                 }
> 177:                 theConsumer.setPixels(0, y, width, 1, newcm, scanline, 0,
> 178:                         width);

can we revert the white space changes ?

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13408#pullrequestreview-1384184811
PR Review Comment: https://git.openjdk.org/jdk/pull/13408#discussion_r1164740594