RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

Jeremy duke at openjdk.org
Fri Apr 14 01:54:49 UTC 2023


> This resolves a 25 year old P4 ticket: a NullPointerException is printed to System.err needlessly.
> 
> This resolution involves confirming that an ImageConsumer is still registered before every notification.
> 
> I'll understand if this is rejected as unimportant, but I stumbled across this in the real world the other day and thought this was a simple enough bug to practice on.

Jeremy has updated the pull request incrementally with one additional commit since the last revision:

  4200096: removing whitespace diffs
  
  prrace pointed out this branch introduced some pointless whitespace changes.
  https://github.com/openjdk/jdk/pull/13408#discussion_r1164740594

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13408/files
  - new: https://git.openjdk.org/jdk/pull/13408/files/ff469b23..fd751f57

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13408&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13408&range=04-05

  Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/13408.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13408/head:pull/13408

PR: https://git.openjdk.org/jdk/pull/13408



More information about the client-libs-dev mailing list