RFR: 8305578: X11GraphicsDevice.pGetBounds() is slow in remote X11 sessions [v3]
Alexey Ushakov
avu at openjdk.org
Fri Apr 14 10:32:36 UTC 2023
On Thu, 13 Apr 2023 15:37:29 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:
>> Getting bounds of a `GraphicsDevice` and insets of a screen are fairly frequent operations. When working over the network (remote X session), those can take several *seconds* to complete, introducing repeated freezes even when typing in an editor feels only slightly sluggish.
>>
>> On the other hand, neither bounds nor insets change very often - if at all - during the lifetime of an application. So caching their values seems like a natural solution to the problem. The caches need to be reset only when there's a possibility of change in the screens configuration.
>>
>> A similar patch has been living in [JetBrains Runtime](https://github.com/JetBrains/JetBrainsRuntime/) for well over a year.
>
> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>
> Reverted the copyright year in X11GraphicsEnvironment.java
Looks good for me
-------------
Marked as reviewed by avu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/13346#pullrequestreview-1385191885
More information about the client-libs-dev
mailing list