RFR: 8306135: Clean up and open source some AWT tests [v2]

Alexander Zuev kizune at openjdk.org
Tue Apr 18 20:17:02 UTC 2023


On Tue, 18 Apr 2023 19:08:19 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Cosmitic change: couple of extra-long strings were reformatted to be shorter
>>  - Added a line separating class declaration from imports
>
> test/jdk/java/awt/Cursor/SingleColorCursorTest.java line 42:
> 
>> 40: import java.awt.image.BufferedImage;
>> 41: import java.lang.reflect.InvocationTargetException;
>> 42: public class SingleColorCursorTest extends Panel {
> 
> Can you add empty line between class and the import statement

Done

> test/jdk/java/awt/Dialog/ComponentShownEvent.java line 86:
> 
>> 84:     }
>> 85: 
>> 86:     public static void main(String[] args) throws InterruptedException, InvocationTargetException, AWTException {
> 
> Can you set to 80-column limit.

Now trying to keep the lines lengths reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13518#discussion_r1170518141
PR Review Comment: https://git.openjdk.org/jdk/pull/13518#discussion_r1170521433



More information about the client-libs-dev mailing list