RFR: JDK-8304291: [AIX] Broken build after JDK-8301998

[Tyler Steele]

On Wed, 19 Apr 2023 10:38:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> After the latest harfbuzz update, the AIX build is broken.  The old clang compiler from xlc16 does not compile harfbuzz correctly.
> First issue in hb-algs.hh is that xlc16 clang still sets some GNUC-related macros, so we do not run into the  `__clang_major__ >= 8`  check that should prevent to try to compile  `__builtin_mul_overflow`   with ancient clang.
> The other issue in  `hb-subset.cc`  is a bit tricky and has been observed as well on macOS when very old clang versions were used.
> 
> Probably we can get rid of those 2 workarounds in some months after switching to xlc17 which includes a rather new clang version.

I really appreciate your work on this one @MBaesken! This fix looks good.

I agree with Martin that we will want this to make its way to jdk17 and 11. Let me know if you would like me to take point on that task.

-------------

Marked as reviewed by tsteele (Committer).

PR Review: https://git.openjdk.org/jdk/pull/13529#pullrequestreview-1392448631