RFR: 8305942: Open source several AWT Focus related tests

Andrey Turbanov aturbanov at openjdk.org
Wed Apr 19 19:14:47 UTC 2023


On Wed, 19 Apr 2023 09:16:04 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> This opensources several other AWT Focus related tests.
> CI runs are ok.

test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java line 52:

> 50:         Thread t1 = new Thread() {
> 51:             public void run() {
> 52:                 synchronized(frame1) {

Suggestion:

                synchronized (frame1) {

test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java line 54:

> 52:                 synchronized(frame1) {
> 53:                     frame1.dispose();
> 54:                     synchronized(frame1) {

Suggestion:

                    synchronized (frame1) {

test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java line 61:

> 59:         };
> 60:         try {
> 61:             synchronized(frame1) {

Suggestion:

            synchronized (frame1) {

test/jdk/java/awt/Focus/TemporaryLostComponentDeadlock.java line 65:

> 63:                 frame1.wait();
> 64:             }
> 65:         } catch( InterruptedException ie) {

Suggestion:

        } catch (InterruptedException ie) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1171754879
PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1171755129
PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1171755394
PR Review Comment: https://git.openjdk.org/jdk/pull/13527#discussion_r1171755534



More information about the client-libs-dev mailing list