RFR: 8071693: Introspector ignores default interface methods [v2]

Archie L. Cobbs duke at openjdk.org
Thu Apr 20 13:51:21 UTC 2023


On Thu, 20 Apr 2023 11:11:08 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Archie L. Cobbs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Set.of() to initialize IGNORABLE_INTERFACES set.
>
> src/java.desktop/share/classes/com/sun/beans/introspect/MethodInfo.java line 112:
> 
>> 110:                     if ((method.getModifiers() & Modifier.ABSTRACT) == 0)
>> 111:                         (list = createIfNeeded(list)).add(method);
>> 112:                 }
> 
> Please always use braces even if the body has only one statement.

OK, I'll fix. I've seen examples of both styles in the JDK so am never really sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13544#discussion_r1172620735



More information about the client-libs-dev mailing list