RFR: 8289547 : Update javax/swing/Popup/TaskbarPositionTest.java
Renjith Kannath Pariyangad
duke at openjdk.org
Fri Apr 21 13:34:49 UTC 2023
Hi Reviewers,
Noticed this test case not verifying all the cases which is intended. Modified it for improving the coverage for 3 type of popups (menu, context menu and combobox).
Evaluating conditions:
1. Not enough space for showing popup downwards(default layout), it should show upwards
2. Window starts from negative position, Popup should show on visible area
For achieving this following areas are modified
- Updated isPopupOnScreen by adding Additional checks (like the position of combobox popup is always verified)
- Menu creation made as function and reused for all menu creation.
- Updated ComboPopupCheckListener class and modified its popupMenuWillBecomeInvisible function. Made it as generic and it is capable to evaluate any combo box's position if this class set as its listener.
- This test case is not intended for multi monitor setup so added a check for identifying monitor, else error out.
- Updated CTRL_MASK to CTRL_DOWN_MASK for removing depreciation warnings and removed some other warnings.
Please review this
Regards,
Renjith.
-------------
Commit messages:
- Removed executable mode
- JDK-8289547 : Update javax/swing/Popup/TaskbarPositionTest.java
Changes: https://git.openjdk.org/jdk/pull/13578/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13578&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289547
Stats: 244 lines in 1 file changed: 130 ins; 54 del; 60 mod
Patch: https://git.openjdk.org/jdk/pull/13578.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13578/head:pull/13578
PR: https://git.openjdk.org/jdk/pull/13578
More information about the client-libs-dev
mailing list