RFR: 8306575: Clean up and open source four Dialog related tests [v2]

Alexander Zuev kizune at openjdk.org
Sat Apr 22 00:21:07 UTC 2023


On Fri, 21 Apr 2023 21:23:57 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added couple of empty lines to make code nore readable.
>
> test/jdk/java/awt/Dialog/DialogLocationTest.java line 142:
> 
>> 140:         int lastX, lastY;
>> 141:         String message = "Failed in componentMoved() expect:[%d,%d]"
>> 142:                 + " reported: [%d,%d] diff [%d,%d]";
> 
> Can you leave a blank line to separate the method .

Done.

> test/jdk/java/awt/Dialog/ModalDialogOnNonEdt.java line 47:
> 
>> 45: 
>> 46: public class ModalDialogOnNonEdt {
>> 47:     public void start () {
> 
> Can you leave a blank line here

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13592#discussion_r1174232601
PR Review Comment: https://git.openjdk.org/jdk/pull/13592#discussion_r1174232561



More information about the client-libs-dev mailing list