RFR: 4200096: OffScreenImageSource.removeConsumer NullPointerException [v6]

Sergey Bylokhov serb at openjdk.org
Sat Apr 22 05:39:45 UTC 2023


On Fri, 14 Apr 2023 01:54:49 GMT, Jeremy <duke at openjdk.org> wrote:

>> This resolves a 25 year old P4 ticket: a NullPointerException is printed to System.err needlessly.
>> 
>> This resolution involves confirming that an ImageConsumer is still registered before every notification.
>> 
>> I'll understand if this is rejected as unimportant, but I stumbled across this in the real world the other day and thought this was a simple enough bug to practice on.
>
> Jeremy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   4200096: removing whitespace diffs
>   
>   prrace pointed out this branch introduced some pointless whitespace changes.
>   https://github.com/openjdk/jdk/pull/13408#discussion_r1164740594

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13408#pullrequestreview-1396575914



More information about the client-libs-dev mailing list