RFR: 8306067: Open source AWT Graphics, GridBagLayout related tests

Andrey Turbanov aturbanov at openjdk.org
Sun Apr 23 19:44:44 UTC 2023


On Fri, 21 Apr 2023 04:00:39 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> This opensources few AWT Graphics & GridBagLayout tests

test/jdk/java/awt/GridBagLayout/GridBagLayoutButtonsOverlapTest.java line 81:

> 79: 
> 80:         c.weightx = 0.0;
> 81:         b5 =  makeButton("button5", gridbag, c);

Suggestion:

        b5 = makeButton("button5", gridbag, c);

test/jdk/java/awt/GridBagLayout/GridBagLayoutButtonsOverlapTest.java line 107:

> 105: 
> 106:         int b1Corner = b1.getLocation().y + b1.getHeight();
> 107:         int  b5Corner = b5.getLocation().y;

Suggestion:

        int b5Corner = b5.getLocation().y;

test/jdk/java/awt/GridBagLayout/GridBagLayoutButtonsOverlapTest.java line 114:

> 112:     }
> 113: 
> 114:     protected static Button  makeButton(String name,

Suggestion:

    protected static Button makeButton(String name,

test/jdk/java/awt/GridBagLayout/GridBagLayoutButtonsOverlapTest.java line 117:

> 115:                                  GridBagLayout gridbag,
> 116:                                  GridBagConstraints c) {
> 117:         Button button  = new Button(name);

Suggestion:

        Button button = new Button(name);

test/jdk/java/awt/GridBagLayout/GridBagLayoutOutOfBoundsTest.java line 51:

> 49:                 GridBagConstraints gridBagConstraints;
> 50: 
> 51:                 Button[]  mb = new Button[L];

Suggestion:

                Button[] mb = new Button[L];

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13570#discussion_r1174633174
PR Review Comment: https://git.openjdk.org/jdk/pull/13570#discussion_r1174633209
PR Review Comment: https://git.openjdk.org/jdk/pull/13570#discussion_r1174633222
PR Review Comment: https://git.openjdk.org/jdk/pull/13570#discussion_r1174633248
PR Review Comment: https://git.openjdk.org/jdk/pull/13570#discussion_r1174633284



More information about the client-libs-dev mailing list