RFR: 8071693: Introspector ignores default interface methods [v5]

[Archie Cobbs]

On Mon, 24 Apr 2023 17:30:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Add comment describing what IGNORABLE_INTERFACES is for.
>>  - Put braces around single-line "if" statement clauses in test.
>>  - Merge branch 'master' into JDK-8071693
>>  - Verify static method is not mistakenly identified as property getter.
>>  - Use Modifier.isAbstract() convenience method instead of bit masking test.
>>  - Put braces around single-line "if" statement clauses.
>>  - Use Set.of() to initialize IGNORABLE_INTERFACES set.
>>  - Include default methods inherited from interfaces in bean introspection.
>
> src/java.desktop/share/classes/com/sun/beans/introspect/MethodInfo.java line 111:
> 
>> 109:             for (Class<?> iface : type.getInterfaces()) {
>> 110:                 if (IGNORABLE_INTERFACES.contains(iface))
>> 111:                     continue;
> 
> Suggestion:
> 
>                 if (IGNORABLE_INTERFACES.contains(iface)) {
>                     continue;
>                 }

Thanks - fixed in 8c129960a37.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13544#discussion_r1175600707