RFR: 8306137: Open source several AWT ScrollPane related tests

Phil Race prr at openjdk.org
Mon Apr 24 18:56:15 UTC 2023


On Mon, 24 Apr 2023 17:39:17 GMT, Tejesh R <tr at openjdk.org> wrote:

> Open source few AWT ScrollPane related tests.

> I thought the preferred layout for tests is to use a flat layout without creating _additional folder_ for each test.
> 
> So, `test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java` should be under `ScrollPane`: `test/jdk/java/awt/ScrollPane/ComponentScrollTest.java`.
> 
> Similarly, `test/jdk/java/awt/ScrollPane/ScrollPaneInsets/ScrollPaneExtraScrollBar.java` goes to `test/jdk/java/awt/ScrollPane/ScrollPaneExtraScrollBar.java`.
> 
> The test `test/jdk/java/awt/ScrollPane/RemoveChild` consists of two .java source files. Can the Semaphore class be moved into `ScrollPaneRemoveAdd.java` as a static nested class?

Yes, remove these redundant components where the test consists of just one file.

jtreg creates a separate WD anyway and the longer the path length the more likely we'll run into problems on windows.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13621#issuecomment-1520664771



More information about the client-libs-dev mailing list