RFR: 8306137: Open source several AWT ScrollPane related tests
Tejesh R
tr at openjdk.org
Tue Apr 25 05:51:20 UTC 2023
On Tue, 25 Apr 2023 05:21:26 GMT, Tejesh R <tr at openjdk.org> wrote:
>> test/jdk/java/awt/ScrollPane/RemoveChild/ScrollPaneRemoveAdd.java line 94:
>>
>>> 92: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
>>> 93:
>>> 94: Toolkit.getDefaultToolkit().sync();
>>
>> Shouldn't `sync` be replaced with `Robot.waitForIdle`?
>
> Not sure y both has been used here, will remove sync and test in CI, if its fine there then can be removed.
> > I thought the preferred layout for tests is to use a flat layout without creating _additional folder_ for each test.
> > So, `test/jdk/java/awt/ScrollPane/ComponentScrollTest/ComponentScrollTest.java` should be under `ScrollPane`: `test/jdk/java/awt/ScrollPane/ComponentScrollTest.java`.
> > Similarly, `test/jdk/java/awt/ScrollPane/ScrollPaneInsets/ScrollPaneExtraScrollBar.java` goes to `test/jdk/java/awt/ScrollPane/ScrollPaneExtraScrollBar.java`.
> > The test `test/jdk/java/awt/ScrollPane/RemoveChild` consists of two .java source files. Can the Semaphore class be moved into `ScrollPaneRemoveAdd.java` as a static nested class?
>
> Yes, remove these redundant components where the test consists of just one file.
>
> jtreg creates a separate WD anyway and the longer the path length the more likely we'll run into problems on windows.
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1176032017
More information about the client-libs-dev
mailing list