RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests [v2]

Abhishek Kumar abhiscxk at openjdk.org
Tue Apr 25 09:35:28 UTC 2023


On Tue, 25 Apr 2023 08:25:26 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment update
>
> test/jdk/java/awt/Layout/InsetsTest.java line 43:
> 
>> 41: 
>> 42: public class InsetsTest {
>> 43:         private int leftInsetValue;
> 
> This test uses some strange formatting.

Fixed.

> test/jdk/java/awt/LightweightComponent/LightweightDragTest.java line 52:
> 
>> 50:     int y = 0;
>> 51:     int x2 = 0;
>> 52:     int y2 = 0;
> 
> Do we need to mark all this as volatile?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13633#discussion_r1176256102
PR Review Comment: https://git.openjdk.org/jdk/pull/13633#discussion_r1176256208



More information about the client-libs-dev mailing list