RFR: 8306652: Open source AWT MenuItem related tests [v3]
Phil Race
prr at openjdk.org
Tue Apr 25 17:01:11 UTC 2023
On Tue, 25 Apr 2023 09:16:20 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:
>> This PR is to open source MenuItem AWT tests.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> Timeout removed
Changes requested by prr (Reviewer).
test/jdk/java/awt/MenuItem/EnableTest.java line 51:
> 49: try {
> 50: EventQueue.invokeAndWait(() -> {
> 51: frame = new Frame();
Can we please have a meaningful Frame title here ? "EnableTest" perhaps ?
test/jdk/java/awt/MenuItem/MenuSetLabelTest.java line 51:
> 49: try {
> 50: EventQueue.invokeAndWait(() -> {
> 51: f = new Menu1();
Menu1("MenuSetLabelTest")
test/jdk/java/awt/MenuItem/SetStateTest.java line 49:
> 47: try {
> 48: EventQueue.invokeAndWait(() -> {
> 49: frame = new Frame();
Frame("SetStateTest")
-------------
PR Review: https://git.openjdk.org/jdk/pull/13589#pullrequestreview-1400353605
PR Review Comment: https://git.openjdk.org/jdk/pull/13589#discussion_r1176796235
PR Review Comment: https://git.openjdk.org/jdk/pull/13589#discussion_r1176796687
PR Review Comment: https://git.openjdk.org/jdk/pull/13589#discussion_r1176797090
More information about the client-libs-dev
mailing list