RFR: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface [v2]

Phil Race prr at openjdk.org
Tue Apr 25 22:30:56 UTC 2023


On Thu, 20 Apr 2023 08:48:51 GMT, Martin Desruisseaux <duke at openjdk.org> wrote:

>> `BufferedImage` implements the `WritableRenderedImage` interface. But the Javadoc is copied from `WritableRenderedImage`, while `BufferedImage` does something quite different. In particular, `TileObserver` are ignored. This pull request add `@implSlec` for explaining the default behaviour.
>> 
>> This commit has one specification change in `isTileWritable`: the exception type is changed from `ArrayIndexOutOfBoundsException` to `IllegalArgumentException` for matching the implementation. The logical conditions is also corrected.
>> 
>> This commit contains a trivial code change: `new Point(0,0)` is replaced by `new Point()` for saving a few byte codes.
>
> Martin Desruisseaux has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update documentation for adressing comment on pull requests, with two changes to be discussed:
>   
>   - The "The default implementation" sentence has not yet been removed, for reason discussed on the pull request.
>   - The discussion about (0,0) tile indices mentions the relationship with `getTileMinX()` and `getTileMinY()`.

I have created the CSR https://bugs.openjdk.org/browse/JDK-8306875 and partially filled it,
but the wording of the spec changes need to be settled here before adding them there.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13506#issuecomment-1522499583



More information about the client-libs-dev mailing list