RFR: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface [v2]
Phil Race
prr at openjdk.org
Tue Apr 25 22:50:23 UTC 2023
On Wed, 19 Apr 2023 17:15:24 GMT, Phil Race <prr at openjdk.org> wrote:
>> Martin Desruisseaux has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update documentation for adressing comment on pull requests, with two changes to be discussed:
>>
>> - The "The default implementation" sentence has not yet been removed, for reason discussed on the pull request.
>> - The discussion about (0,0) tile indices mentions the relationship with `getTileMinX()` and `getTileMinY()`.
>
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 1631:
>
>> 1629: * {@linkplain #getRaster() single tile} without checking
>> 1630: * the passed values. No listeners are notified since the
>> 1631: * returned tile is always checked out for writing.
>
> similar to above
"This method" again.
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 1655:
>
>> 1653: * without checking the passed values. No listeners are notified
>> 1654: * since the {@linkplain #getRaster() single tile} is always
>> 1655: * checked out for writing.
>
> similar to above
We have not quite word-for-word duplicated text here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13506#discussion_r1177137191
PR Review Comment: https://git.openjdk.org/jdk/pull/13506#discussion_r1177130655
More information about the client-libs-dev
mailing list