RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

Tejesh R tr at openjdk.org
Wed Apr 26 14:41:24 UTC 2023


On Tue, 25 Apr 2023 17:08:42 GMT, Phil Race <prr at openjdk.org> wrote:

>> The bug was raised specifically for Win2000, also states that it is not reproducible for Windows NT 4.0 and Windows 98. I don't think that this test is specific to Win2000, in JBS they mention about a feature being added from Win2000, hence the fix wasn't applicable to previous versions.
>
> If you ask me for my guess, this check was saying "something new was introduced in Windows 2000" (note that NT 4 and Windows 98 PRE-DATE Windows 2000). And all the other OSes they are looking for come AFTER Windows 2000.
> So they wanted to test on Windows 2000 and LATER.
> However this exact match requirement means that this test has surely been skipped for the last ~ 10 years .. whenever we stopped testing on XP .. 
> And until you remove the check I suspect you have no idea if this test passes today on Windows 10, or is relevant.
> You will need to remove the check, run the test locally and observe, and then run on the CI test system.
> Probably its still valid but you need to be sure.

I tested locally as well as in CI system, all the run's were green.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1177956601



More information about the client-libs-dev mailing list