RFR: 8306137: Open source several AWT ScrollPane related tests [v3]

Phil Race prr at openjdk.org
Wed Apr 26 18:05:23 UTC 2023


On Wed, 26 Apr 2023 16:49:56 GMT, Tejesh R <tr at openjdk.org> wrote:

>> test/jdk/java/awt/ScrollPane/ComponentScrollTest.java line 80:
>> 
>>> 78:                     Thread.sleep(5000);
>>> 79:                 } catch (InterruptedException ie) {
>>> 80:                 }
>> 
>> This `sleep` blocks EDT. Is it intended?
>
> Yeah, I guess 5000 might not be required 1000 might be fine, but either delay or sleep is required I feel.

It seems just wrong to me. This sleep should be on the main thread after returning from invokeAndWait

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13621#discussion_r1178213360



More information about the client-libs-dev mailing list