RFR: 8306409: Open source AWT KeyBoardFocusManger, LightWeightComponent related tests [v2]

Sergey Bylokhov serb at openjdk.org
Wed Apr 26 18:04:53 UTC 2023


On Wed, 26 Apr 2023 06:07:00 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> test/jdk/java/awt/LightweightComponent/LWClobberDragEvent.java line 88:
>> 
>>> 86:             frame.add(lc);
>>> 87:             frame.pack();
>>> 88:             frame.setLocationRelativeTo(null);
>> 
>> I amnot sure but pack and setLocationRelativeTo together was causing some issue of frame location getting updated/jumping around
>>  pointed out during one of my test review last time..please check..
>
>> I amnot sure but pack and setLocationRelativeTo together was causing some issue of frame location getting updated/jumping around pointed out during one of my test review last time..please check..
> 
> It didn't cause any issues for me as of now. Leaving it as it is.

it could cause a problem if called in a different order, setLocationRelativeTo then pack.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13633#discussion_r1178208629



More information about the client-libs-dev mailing list