RFR: 8306466: Open source more AWT Drag & Drop related tests [v2]

Andrey Turbanov aturbanov at openjdk.org
Thu Apr 27 10:57:24 UTC 2023


On Tue, 25 Apr 2023 23:16:33 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> This PR open sources a few more AWT DnD related tests
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove extra folders

test/jdk/java/awt/dnd/SkipDropCompleteTest/SkipDropCompleteTest.java line 56:

> 54:     public void init() {
> 55:         sourceFrame = new SourceFrame();
> 56:         targetFrame  = new TargetFrame();

Suggestion:

        targetFrame = new TargetFrame();

test/jdk/java/awt/dnd/SkipDropCompleteTest/SourceFrame.java line 82:

> 80:     public void dragDropEnd(DragSourceDropEvent dsde) { }
> 81: 
> 82:     public void dragGestureRecognized(DragGestureEvent dge)  {

Suggestion:

    public void dragGestureRecognized(DragGestureEvent dge) {

test/jdk/java/awt/dnd/SkipDropCompleteTest/TransferableObject.java line 52:

> 50:         super();
> 51:         Vector v = new Vector();
> 52:             if(data instanceof String) {

Strange indentation
Suggestion:

        if (data instanceof String) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13653#discussion_r1178971470
PR Review Comment: https://git.openjdk.org/jdk/pull/13653#discussion_r1178971719
PR Review Comment: https://git.openjdk.org/jdk/pull/13653#discussion_r1178972048



More information about the client-libs-dev mailing list