RFR: 8306638: Open source some AWT tests related to datatransfer and Toolkit

[Andrey Turbanov]

On Tue, 25 Apr 2023 13:48:16 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> This PR open sources some tests related to AWT datatransfer and Toolkit.

test/jdk/java/awt/datatransfer/CRLFTest/CRLFTest.java line 192:

> 190:                     // the variable finished is set to true.
> 191:                     pres.exitValue = p.exitValue();
> 192:                     finished  = true;

Suggestion:

                    finished = true;

test/jdk/java/awt/datatransfer/DataConversionDeadlockTest/DataConversionDeadlockTest.java line 187:

> 185:                     // the variable finished is set to true.
> 186:                     pres.exitValue = p.exitValue();
> 187:                     finished  = true;

Suggestion:

                    finished = true;

test/jdk/java/awt/datatransfer/DataFlavor/BestTextFlavorTest/BestTextFlavorTest.java line 83:

> 81: 
> 82:         //Checking whether the selected flavors in both the arrays are same.
> 83:         if(bestFlavor2.match(bestFlavor1)) {

Suggestion:

        if (bestFlavor2.match(bestFlavor1)) {

test/jdk/java/awt/datatransfer/DataFlavor/BestTextFlavorTest/BestTextFlavorTest.java line 100:

> 98:         DataFlavor[] tempFlavor = new DataFlavor[dataflavor.length];
> 99:         int j = 0;
> 100:         for(int i = dataflavor.length - 1  ; i >= 0; i--) {

Suggestion:

        for (int i = dataflavor.length - 1; i >= 0; i--) {

test/jdk/java/awt/datatransfer/FileTransferAWTLockTest/FileTransferAWTLockTest.java line 202:

> 200:                     // the variable finished is set to true.
> 201:                     pres.exitValue = p.exitValue();
> 202:                     finished  = true;

Suggestion:

                    finished = true;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1178974127
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1178973796
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1178973091
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1178973333
PR Review Comment: https://git.openjdk.org/jdk/pull/13642#discussion_r1178973598