RFR: 8306320: BufferedImage spec needs clarification w.r.t its implementation of the WritableRenderedImage interface [v3]
Phil Race
prr at openjdk.org
Thu Apr 27 19:17:28 UTC 2023
On Thu, 27 Apr 2023 13:18:24 GMT, Martin Desruisseaux <duke at openjdk.org> wrote:
>> `BufferedImage` implements the `WritableRenderedImage` interface. But the Javadoc is copied from `WritableRenderedImage`, while `BufferedImage` does something quite different. In particular, `TileObserver` are ignored. This pull request add `@implSlec` for explaining the default behaviour.
>>
>> This commit has one specification change in `isTileWritable`: the exception type is changed from `ArrayIndexOutOfBoundsException` to `IllegalArgumentException` for matching the implementation. The logical conditions is also corrected.
>>
>> This commit contains a trivial code change: `new Point(0,0)` is replaced by `new Point()` for saving a few byte codes.
>
> Martin Desruisseaux has updated the pull request incrementally with one additional commit since the last revision:
>
> Replace "The default implementation" text by "This method".
> Other edits as commented on GitHub issue.
I'll update the CSR.
-------------
Marked as reviewed by prr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13506#pullrequestreview-1404717870
More information about the client-libs-dev
mailing list