RFR: 8307145: windowsaccessbridge.dll is missing 4 critical methods in its C API

Julian Waters jwaters at openjdk.org
Sat Apr 29 19:46:58 UTC 2023


In windowsaccessbridge(-64).dll the following methods are exported in a def file to C API which in turn call their real implementation, which are instance methods of the class WinAccessBridge:

addJavaEventNotification
removeJavaEventNotification
addAccessibilityEventNotification
removeAccessibilityEventNotification


However, they are nowhere to be seen in the actual C interface, in AccessBridgeWindowsEntryPoints.cpp. Your guess is as good as mine as to how on earth MSVC is still capable of compiling and linking this without any errors whatsoever, but in any case, this is a severe oversight and should be properly defined in the C API lest this happy accident within MSVC is fixed by Microsoft in the future

-------------

Commit messages:
 - Declare missing API in header as well
 - windowsaccessbridge.dll is missing 4 critical methods in its C API

Changes: https://git.openjdk.org/jdk/pull/13734/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13734&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307145
  Stats: 29 lines in 2 files changed: 29 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/13734.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13734/head:pull/13734

PR: https://git.openjdk.org/jdk/pull/13734



More information about the client-libs-dev mailing list