RFR: 8311031: JTable header border vertical lines are not aligned with data grid lines [v10]
Alexey Ivanov
aivanov at openjdk.org
Tue Aug 1 10:41:01 UTC 2023
On Mon, 31 Jul 2023 21:07:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JTableHeader/TableHeaderBorderPositionTest.java line 60:
>
>> 58:
>> 59: String[] columnNames = {"Size", "Size"};
>> 60: JTable table = new JTable(data, columnNames);
>
> Suggestion:
>
> String[][] data = {
> {"1", "1"}
> };
> String[] columnNames = {"Size", "Size"};
>
> JTable table = new JTable(data, columnNames);
>
> Let's separate the data — `data` and `columnNames` from the table.
I though about not separating `data` and `columnNames` with a blank line…
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14766#discussion_r1280440208
More information about the client-libs-dev
mailing list