RFR: 8311031: JTable header border vertical lines are not aligned with data grid lines [v9]

Tejesh R tr at openjdk.org
Tue Aug 1 10:41:05 UTC 2023


On Tue, 1 Aug 2023 10:33:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Since we are saving only once, I don't think separate method is required.
>
> It is not required but it separates the duties: the `test` method *verifies* the rendering, it calls `saveImage` to save the image. Such a design is in the spirit of OOP.
> 
> As bonus, it allows one to save the image easily before it is verified or even after each paint is performed, which I used for my own testing. Thus, it has its benefits.
> 
> I'm not insisting, even though I think it's a better design.

Ok, no issues, If it adds something better then I'll update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14766#discussion_r1280439990



More information about the client-libs-dev mailing list