RFR: 8311031: JTable header border vertical lines are not aligned with data grid lines [v12]

Tejesh R tr at openjdk.org
Tue Aug 1 13:05:37 UTC 2023


> The header border uses `g.drawLine` whereas the JTable data grid lines uses `SwingUtilities2.drawVLine` and `SwingUtilities2.drawHLine` to draw horizontal and vertical lines. The SwingUtilities2 uses `Graphics.fillRect` which contributes to the difference between the position of these two lines which happens/visible at higher ui scaling (difference in alignment between vertical lines of these two). The fix propose to use the same methods for metal L&F of JTable header border paint. 
> CI testing shows green.
> 
> ![image](https://github.com/openjdk/jdk/assets/94159358/f6d1d822-55ba-4ad3-9914-d3f68b67a6c5)

Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:

 - Review fix
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8311031
 - Review fix
 - Review fix
 - Review fix
 - Review fix
 - Review fix
 - Review fix
 - Review comment fix
 - Updated based on review comments
 - ... and 4 more: https://git.openjdk.org/jdk/compare/ca7c1208...3e76abaa

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14766/files
  - new: https://git.openjdk.org/jdk/pull/14766/files/afaa4ed8..3e76abaa

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14766&range=11
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14766&range=10-11

  Stats: 226087 lines in 3700 files changed: 114976 ins; 92899 del; 18212 mod
  Patch: https://git.openjdk.org/jdk/pull/14766.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14766/head:pull/14766

PR: https://git.openjdk.org/jdk/pull/14766



More information about the client-libs-dev mailing list