RFR: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel [v8]

Tejesh R tr at openjdk.org
Tue Aug 1 13:35:09 UTC 2023


> "size" label which is _RIGHT_ aligned is cut off on header cell. The issue is not only w.r.t to `JFileChooser` rather it is part of `JTable`. The root caused is found to be that in metal L&F the border insets is set to `(2,2,2,0)` meaning the right most inset value is 0. Hence when UIScaling increases the issue will be visible clearly. The fix addresses the issue by setting the right `inset` to 2 similar to other `inset` values. (Though the reason for setting it to 0 is unclear since it was initial load). 
> CI testing shows green.
> After the fix at 225% scaling:
> ![image](https://github.com/openjdk/jdk/assets/94159358/f3e5a88a-1710-4ee0-84aa-338bc93010b2)

Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:

 - Review fix
 - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8301606
 - Review fix
 - Review fix
 - Review fix
 - Review fix
 - Spacing fix
 - Automated test added
 - Removed white space
 - Fix + Manual Test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14464/files
  - new: https://git.openjdk.org/jdk/pull/14464/files/97e5822a..f1bf39f2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14464&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14464&range=06-07

  Stats: 226087 lines in 3700 files changed: 114976 ins; 92899 del; 18212 mod
  Patch: https://git.openjdk.org/jdk/pull/14464.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14464/head:pull/14464

PR: https://git.openjdk.org/jdk/pull/14464



More information about the client-libs-dev mailing list