RFR: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel [v8]
Tejesh R
tr at openjdk.org
Wed Aug 2 04:17:02 UTC 2023
On Tue, 1 Aug 2023 13:46:03 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Review fix
>> - Merge branch 'master' of https://git.openjdk.java.net/jdk into branch_8301606
>> - Review fix
>> - Review fix
>> - Review fix
>> - Review fix
>> - Spacing fix
>> - Automated test added
>> - Removed white space
>> - Fix + Manual Test
>
> test/jdk/javax/swing/JTableHeader/JTableHeaderLabelRightAlignTest.java line 98:
>
>> 96: }
>> 97:
>> 98: private static void saveBufferedImage(BufferedImage image, String fileName) {
>
> `saveImage` should be enough as in #14766?
I have used `saveBufferedImage` in both the test/PR, I think it should be fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14464#discussion_r1281366973
More information about the client-libs-dev
mailing list