RFR: 4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Aug 3 10:25:37 UTC 2023


On Thu, 3 Aug 2023 03:18:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSeparatorUI.java line 32:
>> 
>>> 30: import java.awt.Graphics;
>>> 31: import java.awt.Insets;
>>> 32: import java.awt.Rectangle;
>> 
>> Neither `Insets`, nor `Rectangle` are used here.
>> Suggestion:
>
> it was there even before this PR but anyway have removed...

They were there, but why are there if they're unused?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15054#discussion_r1282994673



More information about the client-libs-dev mailing list