RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v2]
lawrence.andrews
duke at openjdk.org
Tue Aug 8 21:10:49 UTC 2023
> 1) Used builder pattern
> 2) Tested AWT tests and it passed
lawrence.andrews has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
- Revert changes to PrintLatinCJKTest.java
- Refactor screen capture
Move creating screen capture UI into its own method;
Use enum for meaningful names of capture types,
Use switch to select a capture type.
- Refactor creating an instance of Robot
Moving creating the robot into a separate method provides
- Address review comments
Don't break string unnecessarily, prefer wrapping entire statements;
Align dots in streams;
Inline MRI for the image.
- Merge master
TrayIconScalingTest: accepted theirs, throwing out previous changes
# Conflicts:
# test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java
- minor changes
- Used builder pattern for PassFailJFrame.java
- Merge branch 'master' into PassFailJFrame_Screen_Shot
- Fixed review comments
- Added screen shot functionality to PassFailJFrame.java
-------------
Changes: https://git.openjdk.org/jdk/pull/14094/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14094&range=01
Stats: 223 lines in 1 file changed: 219 ins; 1 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/14094.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14094/head:pull/14094
PR: https://git.openjdk.org/jdk/pull/14094
More information about the client-libs-dev
mailing list