RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v2]

Harshitha Onkar honkar at openjdk.org
Wed Aug 9 17:54:29 UTC 2023


On Tue, 8 Aug 2023 21:10:49 GMT, lawrence.andrews <duke at openjdk.org> wrote:

>> 1) Used builder pattern 
>> 2) Tested AWT tests and it passed
>
> lawrence.andrews has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - Revert changes to PrintLatinCJKTest.java
>  - Refactor screen capture
>    
>    Move creating screen capture UI into its own method;
>    Use enum for meaningful names of capture types,
>    Use switch to select a capture type.
>  - Refactor creating an instance of Robot
>    
>    Moving creating the robot into a separate method provides
>  - Address review comments
>    
>    Don't break string unnecessarily, prefer wrapping entire statements;
>    Align dots in streams;
>    Inline MRI for the image.
>  - Merge master
>    
>    TrayIconScalingTest: accepted theirs, throwing out previous changes
>    
>    # Conflicts:
>    #	test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java
>  - minor changes
>  - Used builder pattern for PassFailJFrame.java
>  - Merge branch 'master' into PassFailJFrame_Screen_Shot
>  - Fixed review comments
>  - Added screen shot functionality to PassFailJFrame.java

Tested by applying PassFailJFrame changes to manual test. Added functionality - Screen capture code works well and since Builder pattern is used, it does not affect existing manual tests. Changes look good.

@lawrence-andrew  Minor: Copyright year needs to be updated for PassFailJFrame.java

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14094#issuecomment-1671855089



More information about the client-libs-dev mailing list